Skip to content

hotfix Drone install Horovod #4038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2020
Merged

hotfix Drone install Horovod #4038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
884d3e8
hotfix Drone install Horovod
Borda Oct 9, 2020
45dd940
notes
Borda Oct 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .drone.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ steps:
CODECOV_TOKEN:
from_secret: codecov_token
MKL_THREADING_LAYER: GNU
HOROVOD_GPU_ALLREDUCE: NCCL
HOROVOD_GPU_BROADCAST: NCCL
HOROVOD_GPU_OPERATIONS: NCCL
HOROVOD_WITH_PYTORCH: 1
HOROVOD_WITHOUT_TENSORFLOW: 1
HOROVOD_WITHOUT_MXNET: 1
Expand All @@ -41,15 +40,18 @@ steps:
# path: /opt/conda/lib/python3.7/site-packages

commands:
# todo: remove unsets as in correct image Horovod shall be set
- unset HOROVOD_GPU_ALLREDUCE
- unset HOROVOD_GPU_BROADCAST
- export PATH="$PATH:/root/.local/bin"
- python --version
- pip install pip -U
- pip --version
- nvidia-smi
#- bash ./requirements/install_AMP.sh
- apt-get update && apt-get install -y cmake
- pip install -r ./requirements/base.txt --user -q --upgrade-strategy only-if-needed
- pip install -r ./requirements/devel.txt --user -q --upgrade-strategy only-if-needed
- pip uninstall -y horovod # todo: this shall not be needed
- pip install -r ./requirements/devel.txt --user -q --upgrade-strategy only-if-needed --no-cache-dir
#- pip install -r ./requirements/docs.txt --user -q
- pip install -r ./requirements/examples.txt --user -q --upgrade-strategy only-if-needed
- pip list
Expand Down
4 changes: 1 addition & 3 deletions pytorch_lightning/utilities/argparse_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,9 @@ def from_argparse_args(cls, args: Union[Namespace, ArgumentParser], **kwargs):
>>> args = Trainer.parse_argparser(parser.parse_args(""))
>>> trainer = Trainer.from_argparse_args(args, logger=False)
"""
# fist check if any args are defined in environment for the class and set as default

if isinstance(args, ArgumentParser):
args = cls.parse_argparser(args)
# if other arg passed, update parameters

params = vars(args)

# we only want to pass in valid Trainer args, the rest may be user specific
Expand Down