add parsing OS env vars #4022
Merged
add parsing OS env vars #4022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
commented
Oct 9, 2020
Borda
commented
Oct 9, 2020
| from pytorch_lightning import Trainer | ||
|
|
||
|
|
||
| def test_passing_env_variables(tmpdir): |
Collaborator
Author
There was a problem hiding this comment.
@williamFalcon is this the priority order you expect?
awaelchli
reviewed
Oct 9, 2020
Comment on lines
+23
to
+24
| Decorator for :class:`~pytorch_lightning.trainer.trainer.Trainer` methods for which | ||
| input arguments should be moved automatically to the correct device. |
Contributor
There was a problem hiding this comment.
hehe, I think I know from where you copied this code :))
this docstring needs to be updated :)
Borda
commented
Oct 9, 2020
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
allow passing some arguments in env si they do not need to be defined again and again
Note: there is no other easy way as we pretty much need all arguments and then kind of return all 40 back
also, we cannot do the assignment with connector without rewriting all connectors as you need to pass
self.my_atributePR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃