use badges only with push #3914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
pushed a commit
that referenced
this pull request
Oct 6, 2020
williamFalcon
added a commit
that referenced
this pull request
Oct 7, 2020
* base * add xfail * new test * import * missing import * xfail if not installed include mkpatch fix test * mock comet comet mocks fix test remove dep undo merge duplication * line * line * convert doctest * doctest * docs * prune Results usage in notebooks (#3911) * notebooks * notebooks * revamp entire metrics (#3868) * removed metric Co-authored-by: Teddy Koker <[email protected]> * added new metrics Co-authored-by: Teddy Koker [email protected] * pep8 Co-authored-by: Teddy Koker [email protected] * pep8 Co-authored-by: Teddy Koker <[email protected]> * docs Co-authored-by: Teddy Koker <[email protected]> * docs Co-authored-by: Teddy Koker <[email protected]> * win ddp tests skip Co-authored-by: Teddy Koker <[email protected]> * win ddp tests skip Co-authored-by: Teddy Koker <[email protected]> * win ddp tests skip Co-authored-by: Teddy Koker <[email protected]> * win ddp tests skip Co-authored-by: Teddy Koker <[email protected]> * reset in compute, cache compute Co-authored-by: Teddy Koker <[email protected]> * reduce_ops handling Co-authored-by: Teddy Koker <[email protected]> * sync -> sync_dist, type annotations Co-authored-by: Teddy Koker <[email protected]> * wip docs Co-authored-by: Teddy Koker <[email protected]> * mean squared error * docstring * added mean ___ error metrics * added mean ___ error metrics * seperated files * accuracy doctest * gpu fix * remove unnecessary mixin * metric and accuracy docstring Co-authored-by: Teddy Koker <[email protected]> * metric docs Co-authored-by: Teddy Koker <[email protected]> * pep8, changelog Co-authored-by: Teddy Koker <[email protected]> * refactor dist utils, pep8 * refactor dist utils, pep8 Co-authored-by: Teddy Koker <[email protected]> * Callback docs with autosummary (#3908) * callback docs with autosummary * do not show private methods * callback base docstring * skip some docker builds (temporally pass) (#3913) * skip some docker builds * todos * skip * use badges only with push (#3914) * testtube * mock test tube * mock mlflow * remove mlflow * clean up * test * test * test * test * test * test * code blocks * remove import * codeblock * logger * wandb causes stall Co-authored-by: William Falcon <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Ananya Harsh Jha <[email protected]> Co-authored-by: Teddy Koker <[email protected]> Co-authored-by: Jeff Yang <[email protected]>
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
use badges just from push to master, not sure what the default was...
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃