Skip to content

Conversation

@vr140
Copy link
Contributor

@vr140 vr140 commented Jul 6, 2020

There are usages of training_dataloader, which is a method that no longer seems to exist in LightningModule. Instead, these usages should be updated to train_dataloader.

@mergify mergify bot requested a review from a team July 6, 2020 04:05
@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

Merging #2521 into master will increase coverage by 1%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2521   +/-   ##
======================================
+ Coverage      88%     89%   +1%     
======================================
  Files          69      69           
  Lines        5628    5628           
======================================
+ Hits         4963    5017   +54     
+ Misses        665     611   -54     

@mergify mergify bot requested a review from a team July 6, 2020 06:29
Copy link
Collaborator

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thx

@Borda Borda added the docs Documentation related label Jul 6, 2020
@mergify mergify bot requested a review from a team July 6, 2020 07:20
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe one thing in the future we could do is with pytest.raises(..) also test for the specific message, not just the error/warning class.

@Borda
Copy link
Collaborator

Borda commented Jul 6, 2020

maybe one thing in the future we could do is with pytest.raises(..) also test for the specific message, not just the error/warning class.

sure, this also simplifies finding what code block it is related...

@Borda Borda merged commit 96b32be into Lightning-AI:master Jul 6, 2020
@vr140 vr140 deleted the vr/trainDataloader branch July 6, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants