Skip to content

Conversation

SkafteNicki
Copy link
Collaborator

@SkafteNicki SkafteNicki commented Aug 13, 2025

What does this PR do?

Tests was passing in PR (#21056), but not on master.
Example of failing tests:
https://github.com/Lightning-AI/pytorch-lightning/actions/runs/16930368766/job/47974302309
https://github.com/Lightning-AI/pytorch-lightning/actions/runs/16918789912/job/47940742066

@Borda

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21063.org.readthedocs.build/en/21063/

@SkafteNicki SkafteNicki added the ci Continuous Integration label Aug 13, 2025
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 13, 2025
@Borda Borda merged commit f775e35 into Lightning-AI:master Aug 13, 2025
46 checks passed
Borda pushed a commit that referenced this pull request Aug 13, 2025
(cherry picked from commit f775e35)
Borda pushed a commit that referenced this pull request Aug 13, 2025
(cherry picked from commit f775e35)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants