-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fixes incorrect strategy init with HPUAccelerator #19615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
awaelchli
merged 3 commits into
Lightning-AI:master
from
ankitgola005:hpu_strategy_init
Mar 14, 2024
Merged
Fixes incorrect strategy init with HPUAccelerator #19615
awaelchli
merged 3 commits into
Lightning-AI:master
from
ankitgola005:hpu_strategy_init
Mar 14, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
reviewed
Mar 13, 2024
awaelchli
approved these changes
Mar 13, 2024
Contributor
awaelchli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
src/lightning/pytorch/trainer/connectors/accelerator_connector.py
Outdated
Show resolved
Hide resolved
Borda
approved these changes
Mar 13, 2024
jerome-habana
approved these changes
Mar 14, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #19615 +/- ##
==========================================
- Coverage 84% 53% -31%
==========================================
Files 424 416 -8
Lines 34903 34752 -151
==========================================
- Hits 29347 18435 -10912
- Misses 5556 16317 +10761 |
awaelchli
added a commit
that referenced
this pull request
Apr 10, 2024
Co-authored-by: Ankit Gola <[email protected]>
lantiga
pushed a commit
that referenced
this pull request
Apr 11, 2024
Co-authored-by: Ankit Gola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accelerator: hpu (external)
Habana Processing Unit
bug
Something isn't working
community
This PR is from the community
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes for incorrect strategy init with HPUAccelerator
Accelerator_connector only picks correct "auto" strategy when accelerator is set as "hpu". setting it with class instance fails this check and it sets default strategy from SingleDeviceStrategy / DDPStrategy instead of SingleHPUStrategy / ParallelHPUStrategy.
Fixes #19614
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--19615.org.readthedocs.build/en/19615/