Skip to content

Conversation

@ankitgola005
Copy link
Contributor

@ankitgola005 ankitgola005 commented Mar 12, 2024

What does this PR do?

Fixes for incorrect strategy init with HPUAccelerator
Accelerator_connector only picks correct "auto" strategy when accelerator is set as "hpu". setting it with class instance fails this check and it sets default strategy from SingleDeviceStrategy / DDPStrategy instead of SingleHPUStrategy / ParallelHPUStrategy.

Fixes #19614

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19615.org.readthedocs.build/en/19615/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Mar 12, 2024
@awaelchli awaelchli added the accelerator: hpu (external) Habana Processing Unit label Mar 13, 2024
@awaelchli awaelchli added this to the 2.2.x milestone Mar 13, 2024
@awaelchli awaelchli added bug Something isn't working community This PR is from the community labels Mar 13, 2024
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify mergify bot added the ready PRs ready to be merged label Mar 13, 2024
@codecov
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Merging #19615 (0ef76eb) into master (096b063) will decrease coverage by 31%.
Report is 4 commits behind head on master.
The diff coverage is 90%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19615      +/-   ##
==========================================
- Coverage      84%      53%     -31%     
==========================================
  Files         424      416       -8     
  Lines       34903    34752     -151     
==========================================
- Hits        29347    18435   -10912     
- Misses       5556    16317   +10761     

@awaelchli awaelchli merged commit 1439da4 into Lightning-AI:master Mar 14, 2024
awaelchli added a commit that referenced this pull request Apr 10, 2024
lantiga pushed a commit that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accelerator: hpu (external) Habana Processing Unit bug Something isn't working community This PR is from the community pl Generic label for PyTorch Lightning package ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Initializing Trainer with accelerator=HPUAccelerator() and strategy="auto" initializes it with incorrect strategies

4 participants