Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Feb 16, 2024

What does this PR do?

Recommends a few optional steps after converting PyTorch code to Fabric.

Fixes #17737


📚 Documentation preview 📚: https://pytorch-lightning--19486.org.readthedocs.build/en/19486/

cc @Borda @carmocca @justusschock @awaelchli

@awaelchli awaelchli added docs Documentation related fabric lightning.fabric.Fabric labels Feb 16, 2024
@awaelchli awaelchli added this to the 2.3 milestone Feb 16, 2024
@awaelchli awaelchli marked this pull request as ready for review February 17, 2024 18:30
@awaelchli awaelchli requested a review from carmocca February 17, 2024 18:30
@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2024

⚡ Required checks status: All passing 🟢

Groups summary

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success
docs-make (fabric, html) success

These checks are required after the changes to docs/source-fabric/fundamentals/convert.rst.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@mergify mergify bot added the ready PRs ready to be merged label Feb 17, 2024
@awaelchli awaelchli merged commit c5ab348 into master Feb 17, 2024
@awaelchli awaelchli deleted the docs/optional-convert-steps branch February 17, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related fabric lightning.fabric.Fabric ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using torch.load instead of fabric.load spawns a zombie process when using DDP

3 participants