Skip to content

Conversation

@justusschock
Copy link
Member

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Followup to #1489

Postpone Error raising to logger instantiation to avoid catching all import errors during import

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@justusschock justusschock requested review from a team, Borda and awaelchli May 25, 2020 08:58
@pep8speaks
Copy link

pep8speaks commented May 25, 2020

Hello @justusschock! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-05-25 09:08:24 UTC

@Borda Borda added the feature Is an improvement or enhancement label May 25, 2020
@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #1938 into master will decrease coverage by 0%.
The diff coverage is 71%.

@@          Coverage Diff           @@
##           master   #1938   +/-   ##
======================================
- Coverage      88%     88%   -0%     
======================================
  Files          74      74           
  Lines        4621    4638   +17     
======================================
+ Hits         4050    4062   +12     
- Misses        571     576    +5     

@williamFalcon williamFalcon merged commit 6456247 into master May 25, 2020
@Borda Borda deleted the logger-warnings branch May 25, 2020 11:49
@Borda Borda modified the milestones: 0.7.7, 0.8.0 May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Is an improvement or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants