fix default arg #1927
Merged
fix default arg #1927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request is now in conflict... :( |
Contributor
|
is the |
Codecov Report
@@ Coverage Diff @@
## master #1927 +/- ##
======================================
Coverage 88% 88%
======================================
Files 74 74
Lines 4621 4607 -14
======================================
- Hits 4050 4048 -2
+ Misses 571 559 -12 |
Collaborator
Author
It was not used anywhere... |
|
|
||
|
|
||
| def pick_single_gpu(exclude_gpus=[]): | ||
| # def retry_jittered_backoff(f, num_retries=5): |
Collaborator
Author
There was a problem hiding this comment.
is this used somewhere?
EDIT: ok, uncommented...
|
Hello @Borda! Thanks for updating this PR.
Comment last updated at 2020-05-26 16:08:38 UTC |
justusschock
pushed a commit
that referenced
this pull request
Jun 29, 2020
* fix default * formatting errors * update * flake8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
remove default list which can be dangerous usage
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃