Allow dataloaders without sampler field present #1907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes we have a custom dataloader that doesn't have a sampler, better to check that the field is there before reading it.
tullie
approved these changes
May 20, 2020
Contributor
tullie
left a comment
tullie
left a comment
There was a problem hiding this comment.
LGTM. Clear improvement, thanks!
tullie
requested review from
a team and
williamFalcon
and removed request for
a team
williamFalcon
approved these changes
May 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #1907 +/- ##
======================================
Coverage 88% 88%
======================================
Files 74 74
Lines 4590 4590
======================================
Hits 4061 4061
Misses 529 529 |
Borda
approved these changes
May 20, 2020
Contributor
|
Great job! =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we have a custom dataloader that doesn't have a sampler, better to check that the field is there before reading it.