Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 21, 2023

What does this PR do?

Follow up to #18591

TODO: Provide examples and numbers showing the warnings don't apply anymore.
TODO: Remove it from docs: https://lightning.ai/docs/pytorch/stable/advanced/speed.html#persistent-workers


📚 Documentation preview 📚: https://pytorch-lightning--18610.org.readthedocs.build/en/18610/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 21, 2023
@awaelchli awaelchli marked this pull request as ready for review September 27, 2023 00:54
@awaelchli awaelchli closed this Sep 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023

⛈️ Required checks status: Has failure 🔴

Warning
This job will need to be re-run to merge your PR. If you do not have write access to the repository, you can ask Lightning-AI/lai-frameworks to re-run it. If you push a new commit, all of CI will re-trigger.

Groups summary

🔴 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, lightning, 3.8, 1.11) failure
pl-cpu (macOS-11, lightning, 3.9, 1.12) failure
pl-cpu (macOS-11, lightning, 3.10, 1.13) failure
pl-cpu (macOS-11, lightning, 3.10, 2.0) failure
pl-cpu (macOS-11, lightning, 3.8, 1.11, oldest) failure
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11) failure
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.12) failure
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13) failure
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.0) failure
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest) failure
pl-cpu (windows-2022, lightning, 3.8, 1.11) failure
pl-cpu (windows-2022, lightning, 3.9, 1.12) failure
pl-cpu (windows-2022, lightning, 3.10, 1.13) failure
pl-cpu (windows-2022, lightning, 3.10, 2.0) failure
pl-cpu (windows-2022, lightning, 3.8, 1.11, oldest) failure
pl-cpu (macOS-11, pytorch, 3.8, 1.13) failure
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13) failure
pl-cpu (windows-2022, pytorch, 3.8, 1.13) failure
pl-cpu (macOS-12, pytorch, 3.11, 2.0) failure
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.0) failure
pl-cpu (windows-2022, pytorch, 3.11, 2.0) failure

These checks are required after the changes to src/lightning/pytorch/trainer/connectors/data_connector.py, tests/tests_pytorch/trainer/connectors/test_data_connector.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
[pytorch-lightning (GPUs) (testing Lightning latest)](https://dev.azure.com/Lightning-AI/72ab7ed8-b00f-4b6e-b131-3388f7ffafa7/_build/results?buildId=175480&view=logs&jobId=47e66f3c-897a-5428-da11-bf5c7745762e) success
[pytorch-lightning (GPUs) (testing PyTorch latest)](https://dev.azure.com/Lightning-AI/72ab7ed8-b00f-4b6e-b131-3388f7ffafa7/_build/results?buildId=175480&view=logs&jobId=3f274fac-2e11-54ca-487e-194c91f3ae9f) success

These checks are required after the changes to src/lightning/pytorch/trainer/connectors/data_connector.py, tests/tests_pytorch/trainer/connectors/test_data_connector.py.

🟢 pytorch_lightning: Benchmarks
Check ID Status
lightning.Benchmarks success

These checks are required after the changes to src/lightning/pytorch/trainer/connectors/data_connector.py.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success
docs-make (pytorch, html) success

These checks are required after the changes to src/lightning/pytorch/trainer/connectors/data_connector.py.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to src/lightning/pytorch/trainer/connectors/data_connector.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.8) success
install-pkg (ubuntu-22.04, app, 3.11) success
install-pkg (ubuntu-22.04, fabric, 3.8) success
install-pkg (ubuntu-22.04, fabric, 3.11) success
install-pkg (ubuntu-22.04, pytorch, 3.8) success
install-pkg (ubuntu-22.04, pytorch, 3.11) success
install-pkg (ubuntu-22.04, lightning, 3.8) success
install-pkg (ubuntu-22.04, lightning, 3.11) success
install-pkg (ubuntu-22.04, notset, 3.8) success
install-pkg (ubuntu-22.04, notset, 3.11) success
install-pkg (macOS-12, app, 3.8) success
install-pkg (macOS-12, app, 3.11) success
install-pkg (macOS-12, fabric, 3.8) success
install-pkg (macOS-12, fabric, 3.11) success
install-pkg (macOS-12, pytorch, 3.8) success
install-pkg (macOS-12, pytorch, 3.11) success
install-pkg (macOS-12, lightning, 3.8) success
install-pkg (macOS-12, lightning, 3.11) success
install-pkg (macOS-12, notset, 3.8) success
install-pkg (macOS-12, notset, 3.11) success
install-pkg (windows-2022, app, 3.8) success
install-pkg (windows-2022, app, 3.11) success
install-pkg (windows-2022, fabric, 3.8) success
install-pkg (windows-2022, fabric, 3.11) success
install-pkg (windows-2022, pytorch, 3.8) success
install-pkg (windows-2022, pytorch, 3.11) success
install-pkg (windows-2022, lightning, 3.8) success
install-pkg (windows-2022, lightning, 3.11) success
install-pkg (windows-2022, notset, 3.8) success
install-pkg (windows-2022, notset, 3.11) success

These checks are required after the changes to src/lightning/pytorch/trainer/connectors/data_connector.py.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@awaelchli awaelchli deleted the feature/remove-old-spawn-warnings branch January 22, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pl Generic label for PyTorch Lightning package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant