Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Aug 15, 2023

What does this PR do?

https://github.com/Lightning-AI/lightning/actions/runs/5867224915

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @carmocca @Borda @tchaton

@Borda Borda added ci Continuous Integration priority: 1 Medium priority task labels Aug 15, 2023
@Borda Borda marked this pull request as ready for review August 15, 2023 14:40
@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2023

⚡ Required checks status: All passing 🟢

Groups summary

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to src/lightning/version.info.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.8) success
install-pkg (ubuntu-22.04, app, 3.10) success
install-pkg (ubuntu-22.04, fabric, 3.8) success
install-pkg (ubuntu-22.04, fabric, 3.10) success
install-pkg (ubuntu-22.04, pytorch, 3.8) success
install-pkg (ubuntu-22.04, pytorch, 3.10) success
install-pkg (ubuntu-22.04, lightning, 3.8) success
install-pkg (ubuntu-22.04, lightning, 3.10) success
install-pkg (ubuntu-22.04, notset, 3.8) success
install-pkg (ubuntu-22.04, notset, 3.10) success
install-pkg (macOS-12, app, 3.8) success
install-pkg (macOS-12, app, 3.10) success
install-pkg (macOS-12, fabric, 3.8) success
install-pkg (macOS-12, fabric, 3.10) success
install-pkg (macOS-12, pytorch, 3.8) success
install-pkg (macOS-12, pytorch, 3.10) success
install-pkg (macOS-12, lightning, 3.8) success
install-pkg (macOS-12, lightning, 3.10) success
install-pkg (macOS-12, notset, 3.8) success
install-pkg (macOS-12, notset, 3.10) success
install-pkg (windows-2022, app, 3.8) success
install-pkg (windows-2022, app, 3.10) success
install-pkg (windows-2022, fabric, 3.8) success
install-pkg (windows-2022, fabric, 3.10) success
install-pkg (windows-2022, pytorch, 3.8) success
install-pkg (windows-2022, pytorch, 3.10) success
install-pkg (windows-2022, lightning, 3.8) success
install-pkg (windows-2022, lightning, 3.10) success
install-pkg (windows-2022, notset, 3.8) success
install-pkg (windows-2022, notset, 3.10) success

These checks are required after the changes to src/lightning/version.info.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda Borda changed the title debug failed release from master drop duplicate version file Aug 15, 2023
@Borda
Copy link
Collaborator Author

Borda commented Aug 15, 2023

It interesting that such a file shall not even be added as it is listed in
https://github.com/Lightning-AI/lightning/blob/a0ca2c8bcdc79e02fa0c249bfef0697c111d9604/.gitignore#L58

@Borda Borda added the bug Something isn't working label Aug 15, 2023
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check when and why it was added?

@Borda
Copy link
Collaborator Author

Borda commented Aug 15, 2023

Did you check when and why it was added?

it was in #17054

@mergify mergify bot added the ready PRs ready to be merged label Aug 15, 2023
@Borda
Copy link
Collaborator Author

Borda commented Aug 15, 2023

@carmocca any idea why Probot does not update with success but keeps canceling?

@Borda Borda merged commit 3002558 into master Aug 15, 2023
@Borda Borda deleted the ci/release branch August 15, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci Continuous Integration priority: 1 Medium priority task ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants