-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Replace obsolete _FakeQueue in multiprocessing launcher
#16873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
⚡ Required checks status: All passing 🟢Groups summary🟢 pytorch_lightning: Tests workflow
These checks are required after the changes to 🟢 pytorch_lightning: Azure GPU
These checks are required after the changes to 🟢 pytorch_lightning: Azure HPU
These checks are required after the changes to 🟢 pytorch_lightning: Docs
These checks are required after the changes to 🟢 mypy
These checks are required after the changes to 🟢 installThese checks are required after the changes to Thank you for your contribution! 💜
|
for more information, see https://pre-commit.ci
What does this PR do?
Fixes #10865
Mini-refactor that removes the
_FakeQueue. This used to be necessary for backward compatibility when LightningModule had theadd_to_queueandget_from_queuehooks. But these were removed and the fake queue can now be replaced by a simple dictionary.The launchers are protected API. No user facing changes.
cc @Borda @justusschock @awaelchli