Bump max deepspeed version to 0.8.0 #16469

awaelchli · 2023-01-22T19:07:00Z

What does this PR do?

Requires #16458

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

Was this discussed/approved via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @akihironitta @Borda @awaelchli @justusschock

github-actions · 2023-01-23T10:36:23Z

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11)	success	✅
pl-cpu (macOS-11, pytorch, 3.9, 1.12)	success	✅
pl-cpu (macOS-11, pytorch, 3.10, 1.13)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 1.10, oldest)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10, oldest)	success	✅
pl-cpu (windows-2022, pytorch, 3.9, 1.11)	success	✅
pl-cpu (windows-2022, pytorch, 3.10, 1.12)	success	✅
pl-cpu (windows-2022, pytorch, 3.10, 1.13)	success	✅
pl-cpu (windows-2022, pytorch, 3.8, 1.10, oldest)	success	✅
pl-cpu (slow, macOS-11, pytorch, 3.8, 1.11)	success	✅
pl-cpu (slow, ubuntu-20.04, pytorch, 3.8, 1.11)	success	✅
pl-cpu (slow, windows-2022, pytorch, 3.8, 1.11)	success	✅
pl-cpu (macOS-11, lightning, 3.8, 1.13)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.13)	success	✅

These checks are required after the changes to requirements/fabric/strategies.txt, requirements/pytorch/strategies.txt.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs)	success	✅

These checks are required after the changes to requirements/pytorch/strategies.txt, requirements/fabric/strategies.txt.

🟢 pytorch_lightning: Benchmarks

Check ID	Status
pytorch-lightning.Benchmark	success	✅

These checks are required after the changes to requirements/pytorch/strategies.txt.

🟢 pytorch_lightning: Azure HPU

Check ID	Status
pytorch-lightning (HPUs)	success	✅

These checks are required after the changes to requirements/fabric/strategies.txt, requirements/pytorch/strategies.txt.

🟢 pytorch_lightning: Azure IPU

Check ID	Status
pytorch-lightning (IPUs)	success	✅

These checks are required after the changes to requirements/fabric/strategies.txt, requirements/pytorch/strategies.txt.

🟢 pytorch_lightning: Docs

Check ID	Status
make-doctest (pytorch)	success	✅
make-html (pytorch)	success	✅

These checks are required after the changes to requirements/pytorch/strategies.txt.

🟢 pytorch_lightning: Docker

Check ID	Status
build-cuda (3.9, 1.10, 11.3.1)	success	✅
build-cuda (3.9, 1.11, 11.3.1)	success	✅
build-cuda (3.9, 1.12, 11.6.1)	success	✅
build-cuda (3.9, 1.13, 11.7.1)	success	✅
build-hpu (1.5.0, 1.11.0)	success	✅
build-ipu (3.9, 1.10)	success	✅
build-NGC	success	✅
build-pl (3.9, 1.10, 11.3.1)	success	✅
build-pl (3.9, 1.11, 11.3.1)	success	✅
build-pl (3.9, 1.12, 11.6.1)	success	✅
build-pl (3.9, 1.13, 11.7.1)	success	✅
build-xla (3.8, 1.12)	success	✅

These checks are required after the changes to requirements/pytorch/strategies.txt, requirements/fabric/strategies.txt.

🟢 lightning_fabric: CPU workflow

Check ID	Status
fabric-cpu (macOS-11, fabric, 3.8, 1.11)	success	✅
fabric-cpu (macOS-11, fabric, 3.9, 1.12)	success	✅
fabric-cpu (macOS-11, fabric, 3.10, 1.13)	success	✅
fabric-cpu (macOS-11, fabric, 3.8, 1.10, oldest)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.10)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.9, 1.11)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.10, 1.12)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.10, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.10, oldest)	success	✅
fabric-cpu (windows-2022, fabric, 3.9, 1.11)	success	✅
fabric-cpu (windows-2022, fabric, 3.10, 1.12)	success	✅
fabric-cpu (windows-2022, fabric, 3.10, 1.13)	success	✅
fabric-cpu (windows-2022, fabric, 3.8, 1.10, oldest)	success	✅
fabric-cpu (macOS-11, lightning, 3.8, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.13)	success	✅
fabric-cpu (windows-2022, lightning, 3.8, 1.13)	success	✅

These checks are required after the changes to requirements/fabric/strategies.txt.

🟢 lightning_fabric: Azure GPU

Check ID	Status
lightning-fabric (GPUs)	success	✅

These checks are required after the changes to requirements/fabric/strategies.txt.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to requirements/fabric/strategies.txt, requirements/pytorch/strategies.txt.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to requirements/fabric/strategies.txt, requirements/pytorch/strategies.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

awaelchli · 2023-01-23T13:52:27Z

CI still installs 0.7.0 😡

.azure/gpu-tests-pytorch.yml

This reverts commit cbd78f2.

This reverts commit 690ce7c.

This reverts commit 4c0be4a.

awaelchli · 2023-02-01T04:16:39Z

I pushed and pulled the docker image per your instructions and now Fabric and PL are installing 0.8.0.

carmocca · 2023-02-01T05:02:19Z

Cool! Let's merge this then

Co-authored-by: Jirka <[email protected]> Co-authored-by: Carlos Mocholí <[email protected]> (cherry picked from commit c1692c6)

bump deepspeed version

fc4a779

github-actions bot added the pl Generic label for PyTorch Lightning package label Jan 22, 2023

awaelchli added ci Continuous Integration strategy: deepspeed fun Staff contributions outside working hours - to differentiate from the "community" label and removed pl Generic label for PyTorch Lightning package labels Jan 22, 2023

awaelchli added this to the v1.9.x milestone Jan 22, 2023

justusschock approved these changes Jan 23, 2023

View reviewed changes

carmocca approved these changes Jan 23, 2023

View reviewed changes

carmocca marked this pull request as ready for review January 23, 2023 10:35

carmocca requested review from Borda, lantiga and tchaton as code owners January 23, 2023 10:35

mergify bot added the ready PRs ready to be merged label Jan 23, 2023

mergify bot added has conflicts and removed ready PRs ready to be merged labels Jan 23, 2023

Merge branch 'master' into ci/bump-deepspeed

2b3bcc2

awaelchli enabled auto-merge (squash) January 23, 2023 12:00

github-actions bot added the pl Generic label for PyTorch Lightning package label Jan 23, 2023

mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jan 23, 2023

Merge branch 'master' into ci/bump-deepspeed

8a6702a

Borda approved these changes Jan 23, 2023

View reviewed changes

mergify bot added has conflicts and removed ready PRs ready to be merged labels Jan 23, 2023

awaelchli disabled auto-merge January 23, 2023 13:50

mergify bot removed the ready PRs ready to be merged label Feb 1, 2023

carmocca reviewed Feb 1, 2023

View reviewed changes

.azure/gpu-tests-pytorch.yml Outdated Show resolved Hide resolved

Merge branch 'master' into ci/bump-deepspeed

2f94154

mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Feb 1, 2023

awaelchli and others added 6 commits February 1, 2023 04:46

nonsense why is it so complicated

4c0be4a

Revert "eager"

e2980b2

This reverts commit cbd78f2.

Revert "eager 2"

b883624

This reverts commit 690ce7c.

stupid

5c309e4

-U means upgrade BUT IT DOESNT

455af59

Revert "nonsense why is it so complicated"

253de34

This reverts commit 4c0be4a.

awaelchli requested a review from carmocca February 1, 2023 04:16

mergify bot added has conflicts and removed ready PRs ready to be merged labels Feb 1, 2023

Merge branch 'master' into ci/bump-deepspeed

bd837af

carmocca enabled auto-merge (squash) February 1, 2023 05:02

mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Feb 1, 2023

Remove -U. Not necessary

8c8c7ce

github-actions bot removed the ci Continuous Integration label Feb 1, 2023

carmocca merged commit c1692c6 into master Feb 1, 2023

carmocca deleted the ci/bump-deepspeed branch February 1, 2023 05:38

Borda pushed a commit that referenced this pull request Feb 9, 2023

Bump max deepspeed version to 0.8.0 (#16469)

e2b632a

Co-authored-by: Jirka <[email protected]> Co-authored-by: Carlos Mocholí <[email protected]> (cherry picked from commit c1692c6)

lantiga pushed a commit that referenced this pull request Feb 10, 2023

Bump max deepspeed version to 0.8.0 (#16469)

8b71299

Co-authored-by: Jirka <[email protected]> Co-authored-by: Carlos Mocholí <[email protected]> (cherry picked from commit c1692c6)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Bump max deepspeed version to 0.8.0 #16469

Bump max deepspeed version to 0.8.0 #16469

Uh oh!

awaelchli commented Jan 22, 2023 •

edited by github-actions bot

Loading

Uh oh!

github-actions bot commented Jan 23, 2023 •

edited

Loading

Uh oh!

awaelchli commented Jan 23, 2023

Uh oh!

Uh oh!

awaelchli commented Feb 1, 2023

Uh oh!

carmocca commented Feb 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Bump max deepspeed version to 0.8.0 #16469

Bump max deepspeed version to 0.8.0 #16469

Uh oh!

Conversation

awaelchli commented Jan 22, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

PR review

Did you have fun?

Uh oh!

github-actions bot commented Jan 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚡ Required checks status: All passing 🟢

Groups summary

Uh oh!

awaelchli commented Jan 23, 2023

Uh oh!

Uh oh!

awaelchli commented Feb 1, 2023

Uh oh!

carmocca commented Feb 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

awaelchli commented Jan 22, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Jan 23, 2023 •

edited

Loading