Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Nov 4, 2022

What does this PR do?

Changes the behavior of loading the global_step.

Current:
Global step gets reloaded regardless of whether you call Trainer.fit(ckpt_path=...) or Trainer.validate(ckpt_path=...), ...

Now:
Global step will only restore its value when calling Trainer.fit(ckpt_path=...). Changed test reflects this behavior.

This is a breaking change, but aligns the behavior as expected for consistency with the rest of our reloading logic.

Discovered in #15500

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @justusschock @carmocca @rohitgr7

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Nov 4, 2022
@awaelchli awaelchli added breaking change Includes a breaking change loops Related to the Loop API labels Nov 4, 2022
@awaelchli awaelchli added this to the v1.9 milestone Nov 4, 2022
@awaelchli awaelchli marked this pull request as ready for review November 4, 2022 14:49
@mergify mergify bot added the ready PRs ready to be merged label Nov 4, 2022
@awaelchli awaelchli enabled auto-merge (squash) November 4, 2022 15:33
@awaelchli awaelchli merged commit 39c6ec9 into master Nov 4, 2022
@awaelchli awaelchli deleted the feature/load-fitstate branch November 4, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Includes a breaking change loops Related to the Loop API pl Generic label for PyTorch Lightning package ready PRs ready to be merged

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants