Skip to content

Conversation

@rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Oct 25, 2022

What does this PR do?

Fixes #14624

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @akihironitta @rohitgr7

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Oct 25, 2022
@rohitgr7 rohitgr7 marked this pull request as ready for review October 25, 2022 14:24
@rohitgr7 rohitgr7 marked this pull request as draft October 25, 2022 14:24
@rohitgr7 rohitgr7 added feature Is an improvement or enhancement tuner labels Oct 25, 2022
@rohitgr7 rohitgr7 self-assigned this Oct 25, 2022
@rohitgr7 rohitgr7 added this to the v1.9 milestone Oct 25, 2022
@rohitgr7 rohitgr7 changed the title Support DDP with LRFinder [wip] Support DDP with LRFinder Oct 25, 2022
@rohitgr7 rohitgr7 marked this pull request as ready for review October 25, 2022 14:56
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on it. I know it is WIP, but wanted to give some feedback for the test. Hope it's useful.

@rohitgr7 rohitgr7 changed the title [wip] Support DDP with LRFinder [wip] [blocked by #15311] Support DDP with LRFinder Oct 28, 2022
@rohitgr7 rohitgr7 requested a review from awaelchli October 28, 2022 18:35
@Borda Borda changed the title [wip] [blocked by #15311] Support DDP with LRFinder [wip] Support DDP with LRFinder Oct 31, 2022
@rohitgr7 rohitgr7 changed the title [wip] Support DDP with LRFinder Support DDP with LRFinder Nov 2, 2022
@mergify mergify bot added the has conflicts label Nov 2, 2022
@rohitgr7 rohitgr7 requested a review from awaelchli November 2, 2022 19:28
@rohitgr7 rohitgr7 changed the title Support DDP with LRFinder [wip] Support DDP with LRFinder Nov 3, 2022
@mergify mergify bot removed the has conflicts label Nov 3, 2022
@rohitgr7 rohitgr7 changed the title [wip] Support DDP with LRFinder Support DDP with LRFinder Nov 3, 2022
@rohitgr7 rohitgr7 requested a review from awaelchli November 3, 2022 12:14
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this looks pretty good! Simple, effective, and easy to reason about!

@carmocca carmocca removed this from the v1.9 milestone Nov 7, 2022
@carmocca carmocca assigned awaelchli and unassigned rohitgr7 Nov 7, 2022
@awaelchli awaelchli added this to the v1.9 milestone Nov 8, 2022
@awaelchli awaelchli added the ready PRs ready to be merged label Nov 8, 2022
@Borda Borda enabled auto-merge (squash) November 8, 2022 17:08
@Borda Borda requested a review from williamFalcon as a code owner November 8, 2022 17:08
@Borda Borda merged commit 1a8f2e8 into master Nov 8, 2022
@Borda Borda deleted the feat/lr_finder_ddp branch November 8, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Is an improvement or enhancement pl Generic label for PyTorch Lightning package ready PRs ready to be merged tuner

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Automatic LR finder for DDP

4 participants