Skip to content

Move type annotation into __init__ #14943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 30, 2022
Merged

Move type annotation into __init__ #14943

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0f6c047
Move type annotation into __init__
ar90n Sep 29, 2022
9b7f190
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 29, 2022
183b273
Merge branch 'master' into move-type-annot-into-init
carmocca Sep 29, 2022
7e7807c
Merge branch 'master' into move-type-annot-into-init
ar90n Sep 30, 2022
e65cfb6
Merge branch 'master' into move-type-annot-into-init
akihironitta Sep 30, 2022
cff8d2e
Merge branch 'master' into move-type-annot-into-init
otaj Sep 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/pytorch_lightning/callbacks/batch_size_finder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@
class BatchSizeFinder(Callback):
SUPPORTED_MODES = ("power", "binsearch")

optimal_batch_size: Optional[int]

def __init__(
self,
mode: str = "power",
Expand Down Expand Up @@ -73,7 +71,7 @@ def __init__(
mode = mode.lower()
if mode not in self.SUPPORTED_MODES:
raise ValueError(f"`mode` should be either of {self.SUPPORTED_MODES}")
self.optimal_batch_size = init_val
self.optimal_batch_size: Optional[int] = init_val
self._mode = mode
self._steps_per_trial = steps_per_trial
self._init_val = init_val
Expand Down