-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Remove deprecated on_init_start_end #14867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated on_init_start_end #14867
Conversation
|
@AndresAlgaba I saw your message earlier and if you have trouble running the tests let me know. You can also check the output of the CI here, for example |
awaelchli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @AndresAlgaba
Feel free to mark the PR as ready for review 😃
|
great work @AndresAlgaba |
Co-authored-by: Adrian Wälchli <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #14867 +/- ##
=========================================
+ Coverage 83% 84% +1%
=========================================
Files 395 327 -68
Lines 28832 25513 -3319
=========================================
- Hits 23902 21371 -2531
+ Misses 4930 4142 -788 |
this code needs to be compatible with old PL versions still
What does this PR do?
Removes deprecated APIs for 1.8 release, #14841. More specifically, the removal of
test_v1_8_0_on_init_start_end.resolves #10940
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃