Clean-up dtype management #14823
Merged
Clean-up dtype management #14823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
requested review from
awaelchli,
justusschock,
kaushikb11,
tchaton and
williamFalcon
as code owners
justusschock
approved these changes
Sep 21, 2022
awaelchli
approved these changes
Sep 21, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #14823 +/- ##
=========================================
+ Coverage 84% 85% +2%
=========================================
Files 395 276 -119
Lines 28922 21182 -7740
=========================================
- Hits 24243 18102 -6141
+ Misses 4679 3080 -1599 |
rohitgr7
pushed a commit
that referenced
this pull request
Sep 24, 2022
Co-authored-by: Justus Schock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Minor cleanup around dtype management. No intended logic changes.
The added tests just increase the coverage.
Does your PR introduce any breaking changes? If yes, please list them.
None
cc @Borda @akihironitta