Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 16, 2022

What does this PR do?

Follow up to #14726.
This PR should be REBASE MERGED

Moves the LightningLite class and wrappers to the standalone package.
There are two commits:

  • Moving the files/classes to the lite package.
  • Add backward compatibility: PL has a subclass implementation in src/pytorch_lightning/lite with:
    • Conversion logic that turns gpus=x and tpu_cores=x into devices=x
    • Conversion logic that turns plugins=PLPrecisionPlugin into plugins=LitePrecisionPlugin
    • Conversion logic that turns strategy=PLStrategy into strategy=LiteStrategy

Please review the two commits separately.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @justusschock @awaelchli @rohitgr7 @carmocca @akihironitta

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 16, 2022
@awaelchli awaelchli added the fabric lightning.fabric.Fabric label Sep 16, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Sep 16, 2022
@awaelchli awaelchli self-assigned this Sep 16, 2022
Base automatically changed from lite/integration to master September 16, 2022 17:25
@awaelchli awaelchli force-pushed the lite/move-lite branch 6 times, most recently from 620e473 to e2c63b0 Compare September 17, 2022 01:42
@awaelchli awaelchli force-pushed the lite/move-lite branch 2 times, most recently from 34e4237 to bb9522a Compare September 18, 2022 20:46
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Sep 20, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package ready PRs ready to be merged refactor

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants