-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Standalone Lite: Move Lite classes #14735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
620e473 to
e2c63b0
Compare
awaelchli
added a commit
that referenced
this pull request
Sep 18, 2022
34e4237 to
bb9522a
Compare
awaelchli
added a commit
that referenced
this pull request
Sep 18, 2022
bb9522a to
bdedcba
Compare
awaelchli
commented
Sep 19, 2022
awaelchli
added a commit
that referenced
this pull request
Sep 19, 2022
awaelchli
added a commit
that referenced
this pull request
Sep 19, 2022
bdedcba to
75bf62c
Compare
awaelchli
added a commit
that referenced
this pull request
Sep 19, 2022
fb9d3ee to
53b5762
Compare
awaelchli
added a commit
that referenced
this pull request
Sep 19, 2022
53b5762 to
ae902c0
Compare
awaelchli
added a commit
that referenced
this pull request
Sep 19, 2022
ae902c0 to
154195a
Compare
awaelchli
added a commit
that referenced
this pull request
Sep 19, 2022
154195a to
c3976e5
Compare
awaelchli
commented
Sep 19, 2022
carmocca
reviewed
Sep 19, 2022
awaelchli
added a commit
that referenced
this pull request
Sep 19, 2022
c3976e5 to
67ef2c0
Compare
carmocca
approved these changes
Sep 19, 2022
awaelchli
added a commit
that referenced
this pull request
Sep 19, 2022
67ef2c0 to
749f4c0
Compare
11 tasks
justusschock
approved these changes
Sep 20, 2022
749f4c0 to
eff8f55
Compare
tchaton
approved these changes
Sep 20, 2022
Contributor
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
awaelchli
added a commit
that referenced
this pull request
Sep 20, 2022
rohitgr7
pushed a commit
that referenced
this pull request
Sep 24, 2022
rohitgr7
pushed a commit
that referenced
this pull request
Sep 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow up to #14726.
This PR should be REBASE MERGED
Moves the LightningLite class and wrappers to the standalone package.
There are two commits:
src/pytorch_lightning/litewith:gpus=xandtpu_cores=xintodevices=xplugins=PLPrecisionPluginintoplugins=LitePrecisionPluginstrategy=PLStrategyintostrategy=LiteStrategyPlease review the two commits separately.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @Borda @justusschock @awaelchli @rohitgr7 @carmocca @akihironitta