Skip to content

Conversation

@carmocca
Copy link
Contributor

@carmocca carmocca commented Sep 13, 2022

What does this PR do?

Replaces CircleCI for GitHub actions to launch TPU tests.
This has the benefit that we can make TPU tests work on forks and mark them as required again.

Closes #14307
Part of #13572

Does your PR introduce any breaking changes? If yes, please list them.

None

cc @carmocca @akihironitta @Borda

@carmocca carmocca added the ci Continuous Integration label Sep 13, 2022
@carmocca carmocca self-assigned this Sep 13, 2022
@carmocca carmocca closed this Sep 20, 2022
@carmocca carmocca deleted the ci/migrate-tpu branch September 20, 2022 12:02
@carmocca carmocca restored the ci/migrate-tpu branch September 30, 2022 00:42
@carmocca carmocca reopened this Sep 30, 2022
@carmocca
Copy link
Contributor Author

This is working!! 😮

@carmocca carmocca added this to the pl:1.8 milestone Sep 30, 2022
@carmocca
Copy link
Contributor Author

Waiting for #14926

@carmocca carmocca modified the milestones: v1.8, v1.9 Oct 13, 2022
@carmocca carmocca marked this pull request as draft October 13, 2022 21:13
@Borda Borda modified the milestones: v1.9, v1.8.x Oct 13, 2022
@carmocca carmocca marked this pull request as ready for review October 19, 2022 11:50
Copy link
Collaborator

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asked @lexierule to setup secrets 🦦

@carmocca
Copy link
Contributor Author

@Borda the secrets are already set up and working. This is just blocked by coverage issues

@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Oct 20, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Oct 20, 2022
@Borda
Copy link
Collaborator

Borda commented Oct 21, 2022

Secrets shall be set, thx @lantiga 🐰

@lantiga lantiga merged commit 375ab53 into master Oct 21, 2022
@lantiga lantiga deleted the ci/migrate-tpu branch October 21, 2022 18:01
@carmocca carmocca modified the milestones: v1.8.x, v1.8 Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration pl Generic label for PyTorch Lightning package ready PRs ready to be merged

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants