Removes timeout from streamlit e2e test #14667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a timeout on the app view which waits for the button but it causes a refresh on the page which causes playwright to miss the button on each refresh. we can remove the timeout altogether since we have a time limit on the test itself in the CI setup
nohalon
requested review from
awaelchli,
hhsecond,
manskx and
tchaton
as code owners
github-actions
bot
added
the
app (removed)
rusenask
approved these changes
Sep 12, 2022
krshrimali
pushed a commit
that referenced
this pull request
Sep 16, 2022
* Removes timeout from streamlit e2e test We have a timeout on the app view which waits for the button but it causes a refresh on the page which causes playwright to miss the button on each refresh. we can remove the timeout altogether since we have a time limit on the test itself in the CI setup Co-authored-by: thomas chaton <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
lexierule
pushed a commit
that referenced
this pull request
Sep 19, 2022
* Removes timeout from streamlit e2e test We have a timeout on the app view which waits for the button but it causes a refresh on the page which causes playwright to miss the button on each refresh. we can remove the timeout altogether since we have a time limit on the test itself in the CI setup Co-authored-by: thomas chaton <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the streamlit end to end test we have a timeout on the app view which waits for a button. However, the timeout causes a refresh on the page which causes playwright to miss the button on each refresh. We can remove the timeout altogether since we have a time limit on the test itself in the CI setup
What does this PR do?
Removes unnecessary timeout from streamlit e2e test which is causing issues.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃