Skip to content

Conversation

@Felonious-Spellfire
Copy link
Contributor

@Felonious-Spellfire Felonious-Spellfire commented Sep 1, 2022

Updated basic debugging topic

What does this PR do?

Adds missing content about printing the model summary if .fit() is not called.

Fixes #14487

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @Felonious-Spellfire @akihironitta

Updated basic debugging topic
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 1, 2022
@Felonious-Spellfire Felonious-Spellfire added the docs Documentation related label Sep 1, 2022
@mergify mergify bot added the ready PRs ready to be merged label Sep 1, 2022
@rohitgr7 rohitgr7 added this to the pl:1.8 milestone Sep 1, 2022
@rohitgr7
Copy link
Contributor

rohitgr7 commented Sep 1, 2022

@Felonious-Spellfire you can just write

Fixes #<issue_num_1>
Fixes #<issue_num_2>

in the PR description. This will link the issue to the PR, which will close automatically when it gets merged.

@rohitgr7 rohitgr7 merged commit b19b155 into master Sep 2, 2022
@rohitgr7 rohitgr7 deleted the Issue_14487 branch September 2, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related pl Generic label for PyTorch Lightning package ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How do I print the model summary if .fit() is not called

4 participants