Skip to content

Fix mypy errors attributed to pytorch_lightning.profilers.pytorch #14405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Sep 13, 2022
Merged

Fix mypy errors attributed to pytorch_lightning.profilers.pytorch #14405

merged 21 commits into from
Sep 13, 2022

Conversation

@krishnakalyan3
Copy link
Contributor

@krishnakalyan3 krishnakalyan3 commented Aug 26, 2022

Part of #13445

@krishnakalyan3 krishnakalyan3 marked this pull request as draft August 26, 2022 11:47
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 26, 2022
@otaj otaj mentioned this pull request Aug 26, 2022
Closed
52 tasks
krishnakalyan3
krishnakalyan3 commented Aug 29, 2022
View reviewed changes
Copy link
Contributor Author

@krishnakalyan3 krishnakalyan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix conflicts

krishnakalyan3
krishnakalyan3 commented Aug 29, 2022
View reviewed changes
Copy link
Contributor Author

@krishnakalyan3 krishnakalyan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix conflicts

krishnakalyan3
krishnakalyan3 commented Aug 29, 2022
View reviewed changes
Copy link
Contributor Author

@krishnakalyan3 krishnakalyan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit

@rohitgr7 rohitgr7 marked this pull request as ready for review August 29, 2022 12:08
@krishnakalyan3
Copy link
Contributor Author

krishnakalyan3 commented Aug 29, 2022

Thank you @rohitgr7. I will look at the changes.

@rohitgr7 rohitgr7 added this to the pl:1.8 milestone Aug 29, 2022
awaelchli
awaelchli approved these changes Sep 8, 2022
View reviewed changes
@mergify mergify bot added the ready PRs ready to be merged label Sep 8, 2022
@Borda Borda enabled auto-merge (squash) September 9, 2022 18:54
rohitgr7
rohitgr7 reviewed Sep 12, 2022
View reviewed changes
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Sep 13, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Sep 13, 2022
@Borda Borda merged commit f68c090 into Lightning-AI:master Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

+2 more reviewers

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@awaelchli awaelchli awaelchli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code quality pl Generic label for PyTorch Lightning package ready PRs ready to be merged

Projects

None yet

Milestone

v1.8

Development

Successfully merging this pull request may close these issues.

5 participants

@krishnakalyan3 @awaelchli @Borda @rohitgr7 @otaj