Skip to content

Conversation

@otaj
Copy link
Contributor

@otaj otaj commented Aug 26, 2022

What does this PR do?

Removes deprecated TrainerCallbackHookMixin. Also, is a followup to #13807

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @tchaton @rohitgr7

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 26, 2022
@otaj otaj changed the title Remove deprecated CallBackHookMixin Remove deprecated TrainerCallbackHookMixin Aug 26, 2022
@otaj otaj added this to the pl:1.8 milestone Aug 26, 2022
@otaj otaj self-assigned this Aug 26, 2022
@otaj otaj added the deprecation Includes a deprecation label Aug 26, 2022
@justusschock justusschock enabled auto-merge (squash) August 26, 2022 08:27
@mergify mergify bot added the ready PRs ready to be merged label Aug 26, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Aug 26, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Aug 28, 2022
@codecov
Copy link

codecov bot commented Aug 28, 2022

Codecov Report

Merging #14401 (ee305c0) into master (03f2f32) will increase coverage by 15%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #14401     +/-   ##
=========================================
+ Coverage      61%      76%    +15%     
=========================================
  Files         332      331      -1     
  Lines       26866    26691    -175     
=========================================
+ Hits        16417    20237   +3820     
+ Misses      10449     6454   -3995     

@justusschock justusschock merged commit 1e04951 into master Aug 28, 2022
@justusschock justusschock deleted the deprecated/remove_callback_hook branch August 28, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation Includes a deprecation pl Generic label for PyTorch Lightning package ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants