Skip to content

Conversation

@rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Aug 26, 2022

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @rohitgr7

@rohitgr7 rohitgr7 added the docs Documentation related label Aug 26, 2022
@rohitgr7 rohitgr7 added this to the pl:1.8 milestone Aug 26, 2022
@rohitgr7 rohitgr7 requested a review from Borda as a code owner August 26, 2022 07:54
@rohitgr7 rohitgr7 self-assigned this Aug 26, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 26, 2022
@mergify mergify bot added the ready PRs ready to be merged label Aug 26, 2022
@rohitgr7 rohitgr7 enabled auto-merge (squash) August 26, 2022 08:07
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #14398 (abd8d7b) into master (f357417) will increase coverage by 15%.
The diff coverage is n/a.

❗ Current head abd8d7b differs from pull request most recent head c8d30a0. Consider uploading reports for the commit c8d30a0 to get more accurate results

@@            Coverage Diff            @@
##           master   #14398     +/-   ##
=========================================
+ Coverage      61%      76%    +15%     
=========================================
  Files         332      332             
  Lines       26861    26898     +37     
=========================================
+ Hits        16417    20445   +4028     
+ Misses      10444     6453   -3991     

@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Aug 26, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Aug 26, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Aug 26, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Aug 27, 2022
@mergify mergify bot added the ready PRs ready to be merged label Aug 27, 2022
@rohitgr7 rohitgr7 merged commit af688de into master Aug 27, 2022
@rohitgr7 rohitgr7 deleted the docs/chlog_post_173 branch August 27, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related pl Generic label for PyTorch Lightning package ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants