Skip to content

Conversation

@carmocca
Copy link
Contributor

@carmocca carmocca commented Aug 23, 2022

What does this PR do?

See title, resolves #12182

Does your PR introduce any breaking changes? If yes, please list them.

Removes deprecated code

Before submitting

  • [n/a] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @justusschock @awaelchli @rohitgr7 @Borda @carmocca @ananthsub @ninginthecloud

@carmocca carmocca added refactor breaking change Includes a breaking change loops Related to the Loop API labels Aug 23, 2022
@carmocca carmocca added this to the pl:1.8 milestone Aug 23, 2022
@carmocca carmocca self-assigned this Aug 23, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 23, 2022
@carmocca carmocca requested a review from otaj as a code owner August 23, 2022 22:42
@carmocca carmocca enabled auto-merge (squash) August 26, 2022 10:24
@mergify mergify bot added the ready PRs ready to be merged label Aug 26, 2022
@carmocca carmocca merged commit d4bcafa into master Aug 26, 2022
@carmocca carmocca deleted the refactor/remove-deprecated-old-loop-format branch August 26, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Includes a breaking change loops Related to the Loop API pl Generic label for PyTorch Lightning package ready PRs ready to be merged refactor

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants