Skip to content

Conversation

@alecmerdler
Copy link
Contributor

What does this PR do?

The local app '/admin' route is being removed because it does
not provide any value, so we need to remove references from it
in the CLI.

Does your PR introduce any breaking changes? If yes, please list them.

  • When running locally with lightning run app, the /admin route is no longer available

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@alecmerdler alecmerdler self-assigned this Aug 18, 2022
@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Aug 18, 2022
@mergify mergify bot added the ready PRs ready to be merged label Aug 19, 2022
@mergify mergify bot requested a review from a team August 19, 2022 08:49
The local app '/admin' route is being removed because it does
not provide any value, so we need to remove references from it
in the CLI.
@alecmerdler
Copy link
Contributor Author

@awaelchli Since I'm not a maintainer, not all of the CI tests will pass for this PR. Are you able to force-merge it for me?

@awaelchli
Copy link
Contributor

Oh @alecmerdler, you are pushing it from a fork. If you had created the branch directly on this repo, it would have been possible to run all CI jobs. We are still waiting for #13927. None of us can force merge anything. Only admin can. So I will ask admin :)

@lexierule lexierule merged commit 0b1a29b into Lightning-AI:master Aug 19, 2022
nicolai86 pushed a commit that referenced this pull request Aug 23, 2022
The local app '/admin' route is being removed because it does
not provide any value, so we need to remove references from it
in the CLI.
@awaelchli awaelchli added this to the app:0.6 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app (removed) Generic label for Lightning App package ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants