adding CI for e2e on Azure #14282
adding CI for e2e on Azure #14282
Conversation
github-actions
bot
removed
the
app (removed)
manskx
left a comment
manskx
left a comment
There was a problem hiding this comment.
looks great !
there's a failed testcase, not sure if it's related
We can merge it as it is and investigate the failure in following PR? |
| strategy: | ||
| matrix: | ||
| 'App: v0_app': | ||
| name: "v0_app" |
There was a problem hiding this comment.
This PR should also update the job names for check group
Also the new name for this file
There was a problem hiding this comment.
This PR should also update the job names for check group
done, note that with Azure we can name the group only no need to list all particular jobs unless we really need :)
Also the new name for this file
what is wrong with it?
There was a problem hiding this comment.
what is wrong with it?
This line: https://github.com/Lightning-AI/lightning/blob/9cf9bc582002a9fc3e0d3b890dc1aff9734cc870/.github/checkgroup.yml#L111 covered the previous job name. Now a new line needs to be added for .azure/app-*
Whenever we do changes to the CI filenames or the names of the jobs run per CI file, we need to keep in mind checkgroup
* start CI * wip * matrix * name * wip * prune * rm * ls * cache * dir * ls * name * cleaning * clone * git * git * if * private * . * local_id * clean * var * group check * ci
7 participants
What does this PR do?
REsolves #13927
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @carmocca @akihironitta @Borda