Skip to content

Conversation

@Jungwon-Lee
Copy link
Contributor

@Jungwon-Lee Jungwon-Lee commented Aug 15, 2022

What does this PR do?

Part of #13445.

Fix typing errors in pytorch_lightning/trainer/trainer.py

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 15, 2022
@Jungwon-Lee Jungwon-Lee force-pushed the typing_trainer branch 2 times, most recently from 3fc29a2 to bb881a2 Compare August 15, 2022 11:21
@otaj otaj mentioned this pull request Aug 15, 2022
52 tasks
@otaj otaj added this to the pl:1.8 milestone Aug 15, 2022
@awaelchli awaelchli added code quality community This PR is from the community labels Aug 15, 2022
@mergify mergify bot removed the has conflicts label Sep 27, 2022
@mergify mergify bot removed the has conflicts label Sep 29, 2022
@otaj otaj requested a review from SkafteNicki as a code owner September 29, 2022 12:41
@mergify mergify bot removed the has conflicts label Sep 29, 2022
@mergify mergify bot added the ready PRs ready to be merged label Sep 30, 2022
@otaj otaj self-assigned this Sep 30, 2022
@otaj otaj enabled auto-merge (squash) September 30, 2022 08:24
@otaj otaj merged commit a9142d6 into Lightning-AI:master Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code quality community This PR is from the community pl Generic label for PyTorch Lightning package ready PRs ready to be merged

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants