Skip to content

Conversation

@tchaton
Copy link
Contributor

@tchaton tchaton commented Aug 10, 2022

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Aug 10, 2022
@tchaton tchaton self-assigned this Aug 10, 2022
@tchaton tchaton added this to the app:0.6 milestone Aug 10, 2022
@lexierule lexierule merged commit 5396b18 into master Aug 10, 2022
@lexierule lexierule deleted the resolve_e2e_3 branch August 10, 2022 20:34
jessecambon pushed a commit to jessecambon/lightning that referenced this pull request Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app (removed) Generic label for Lightning App package

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants