Skip to content

Remove duplicated test classes #14122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2022
Merged

Remove duplicated test classes #14122

merged 1 commit into from
Aug 10, 2022

Conversation

@carmocca
Copy link
Contributor

@carmocca carmocca commented Aug 9, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Minor test refactor

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • [n/a] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @akihironitta

@carmocca carmocca added the tests label Aug 9, 2022
@carmocca carmocca added this to the pl:1.8 milestone Aug 9, 2022
@carmocca carmocca self-assigned this Aug 9, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 9, 2022
@mergify mergify bot added the ready PRs ready to be merged label Aug 9, 2022
@Borda Borda merged commit 9b61b1c into master Aug 10, 2022
@Borda Borda deleted the tests/dupe-classes branch August 10, 2022 15:21
jessecambon pushed a commit to jessecambon/lightning that referenced this pull request Aug 16, 2022
@carmocca @jessecambon
Remove duplicated test classes (Lightning-AI#14122)
7ce928b 
Remove duplicated classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

+2 more reviewers

@awaelchli awaelchli awaelchli approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@carmocca carmocca

Labels

pl Generic label for PyTorch Lightning package ready PRs ready to be merged tests

Projects

None yet

Milestone

v1.8

Development

Successfully merging this pull request may close these issues.

4 participants

@carmocca @awaelchli @Borda @rohitgr7