Fix mypy errors attributed to pytorch_lightning.profilers.simple
#14103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishnakalyan3
requested review from
Borda,
carmocca,
tchaton and
williamFalcon
as code owners
krishnakalyan3
changed the title
pytorch_lightning.profilers.simple
krishnakalyan3
requested review from
awaelchli,
justusschock,
kaushikb11 and
rohitgr7
as code owners
rohitgr7
reviewed
Aug 9, 2022
Codecov Report
@@ Coverage Diff @@
## master #14103 +/- ##
=========================================
+ Coverage 61% 76% +15%
=========================================
Files 324 324
Lines 26366 26411 +45
=========================================
+ Hits 16135 20137 +4002
+ Misses 10231 6274 -3957 |
Contributor
Author
|
@otaj requesting a review. |
rohitgr7
approved these changes
Aug 9, 2022
otaj
approved these changes
Aug 10, 2022
Borda
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #13445