Skip to content

Conversation

@rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Aug 5, 2022

What does this PR do?

See title.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @awaelchli @rohitgr7 @akihironitta @carmocca @justusschock

@rohitgr7 rohitgr7 added bug Something isn't working strategy: deepspeed precision: amp Automatic Mixed Precision labels Aug 5, 2022
@rohitgr7 rohitgr7 added this to the pl:1.7.x milestone Aug 5, 2022
@rohitgr7 rohitgr7 self-assigned this Aug 5, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 5, 2022
@rohitgr7 rohitgr7 marked this pull request as ready for review August 5, 2022 12:16
@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #14041 (3b39e93) into master (d29a552) will increase coverage by 15%.
The diff coverage is 67%.

❗ Current head 3b39e93 differs from pull request most recent head d39819e. Consider uploading reports for the commit d39819e to get more accurate results

@@            Coverage Diff            @@
##           master   #14041     +/-   ##
=========================================
+ Coverage      61%      76%    +15%     
=========================================
  Files         324      324             
  Lines       26369    26422     +53     
=========================================
+ Hits        16138    20148   +4010     
+ Misses      10231     6274   -3957     

@rohitgr7 rohitgr7 requested a review from carmocca August 5, 2022 15:53
@rohitgr7 rohitgr7 force-pushed the bug/deepspeed_mixed branch from 1d09962 to 3b39e93 Compare August 7, 2022 09:08
@rohitgr7 rohitgr7 changed the title Fix precision="mixed" with DeepSpeedStrategy sharded context Fix incorrect precision="mixed" being used with DeepSpeedStrategy and IPUStrategy Aug 7, 2022
@rohitgr7
Copy link
Contributor Author

rohitgr7 commented Aug 7, 2022

should this go as a bugfix or main release now?

@Borda
Copy link
Collaborator

Borda commented Aug 8, 2022

should this go as a bugfix or main release now?

I would say rather bugfix one

@mergify mergify bot added ready PRs ready to be merged has conflicts and removed ready PRs ready to be merged labels Aug 8, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Aug 9, 2022
@rohitgr7 rohitgr7 merged commit ac369f5 into master Aug 9, 2022
@rohitgr7 rohitgr7 deleted the bug/deepspeed_mixed branch August 9, 2022 15:55
awaelchli added a commit that referenced this pull request Aug 9, 2022
… and `IPUStrategy` (#14041)

Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Rohit Gupta <[email protected]>
lexierule pushed a commit that referenced this pull request Aug 9, 2022
… and `IPUStrategy` (#14041)

Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Rohit Gupta <[email protected]>
jessecambon pushed a commit to jessecambon/lightning that referenced this pull request Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working pl Generic label for PyTorch Lightning package precision: amp Automatic Mixed Precision ready PRs ready to be merged strategy: deepspeed

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants