Skip to content

Conversation

@akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Aug 3, 2022

What does this PR do?

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • [n/a] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @akihironitta @Borda @kaushikb11 @rohitgr7

@akihironitta akihironitta added ci Continuous Integration accelerator: tpu Tensor Processing Unit labels Aug 3, 2022
@akihironitta akihironitta changed the title [wip] Ci/fix xla docker [wip] CI: Fix building base-xla docker image Aug 4, 2022
@akihironitta akihironitta self-assigned this Aug 4, 2022
@akihironitta akihironitta changed the title [wip] CI: Fix building base-xla docker image [wip] CI: Fix building base-xla docker image and update its PyTorch version from 1.11 to 1.12 Aug 4, 2022
@akihironitta akihironitta changed the title [wip] CI: Fix building base-xla docker image and update its PyTorch version from 1.11 to 1.12 CI: Fix building base-xla docker image and update its PyTorch version from 1.11 to 1.12 Aug 4, 2022
@akihironitta akihironitta added this to the all:next milestone Aug 4, 2022
@akihironitta akihironitta marked this pull request as ready for review August 5, 2022 01:25
@akihironitta akihironitta changed the title CI: Fix building base-xla docker image and update its PyTorch version from 1.11 to 1.12 CI: Update XLA from 1.9 to 1.12 Aug 5, 2022
@akihironitta akihironitta requested a review from rohitgr7 August 5, 2022 06:59
@awaelchli
Copy link
Contributor

awaelchli commented Aug 5, 2022

Oh no, we have a test failure and it doesn't surface (from master) 😭
Did I mess something up in #11098?
This is so strange, back then, all test errors would always result in a failed CI signal.

@awaelchli awaelchli mentioned this pull request Aug 5, 2022
11 tasks
@mergify mergify bot added the ready PRs ready to be merged label Aug 5, 2022
@awaelchli awaelchli merged commit 0883971 into master Aug 5, 2022
@awaelchli awaelchli deleted the ci/fix-xla-docker branch August 5, 2022 09:04
@awaelchli
Copy link
Contributor

Need to investigate in #14034

awaelchli pushed a commit that referenced this pull request Aug 9, 2022
awaelchli pushed a commit that referenced this pull request Aug 9, 2022
lexierule pushed a commit that referenced this pull request Aug 9, 2022
# Pin mkl version to avoid OSError on torch import
# OSError: libmkl_intel_lp64.so.1: cannot open shared object file: No such file or directory
# https://github.com/pytorch/xla/issues/1666
pip install mkl==2021.4.0 && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akihironitta Why did you pin to this specific release?

I am still seeing the OSError in #14926. I'll try unpinning

Copy link
Contributor Author

@akihironitta akihironitta Sep 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly, that version was the latest release that worked in our CI at the time. I believe there's no other reason, so we can try unpinning it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accelerator: tpu Tensor Processing Unit ci Continuous Integration ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants