Skip to content

Conversation

@alecmerdler
Copy link
Contributor

What does this PR do?

Changes to the Lightning platform UI caused the e2e tests
to break because button text on the project creation dialog
was changed. This fixes the selector.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Aug 2, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@awaelchli awaelchli added this to the app:0.5.x milestone Aug 2, 2022
@mergify mergify bot added the ready PRs ready to be merged label Aug 2, 2022
@mergify mergify bot requested a review from a team August 2, 2022 21:48
@mergify mergify bot requested a review from a team August 3, 2022 14:18
@alecmerdler alecmerdler force-pushed the fix-lightningapp-e2e branch from 4a5634d to 46e5ef5 Compare August 3, 2022 14:23
@alecmerdler alecmerdler force-pushed the fix-lightningapp-e2e branch from 46e5ef5 to 4d3b98a Compare August 4, 2022 03:28
Changes to the Lightning platform UI caused the e2e tests
to break because button text on the project creation dialog
was changed. This fixes the selector.
@alecmerdler alecmerdler force-pushed the fix-lightningapp-e2e branch from 4d3b98a to 806fc78 Compare August 4, 2022 03:29
@awaelchli awaelchli merged commit 332182d into Lightning-AI:master Aug 4, 2022
@tchaton tchaton added the bug Something isn't working label Aug 9, 2022
Borda pushed a commit that referenced this pull request Aug 9, 2022
lexierule pushed a commit that referenced this pull request Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app (removed) Generic label for Lightning App package bug Something isn't working ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants