Skip to content

Conversation

@ethanwharris
Copy link
Member

@ethanwharris ethanwharris commented Aug 1, 2022

What does this PR do?

Can encounter a bug in the following setting (work a, work b, and a file server):

  • work a - puts a file (creating a dir. under that works path)
  • file server - gets the file (lists dirs and checks if any has the file, causing s3fs to cache the list of dirs, see: Add refresh to exists fsspec/s3fs#181 (comment))
  • work b - puts a file
  • file server - tries to get the file but can't see it because of outdated cache

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@ethanwharris ethanwharris added bug Something isn't working app:drive labels Aug 1, 2022
@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Aug 1, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super neat ! Is it the only place ?

@mergify mergify bot added the ready PRs ready to be merged label Aug 2, 2022
@mergify mergify bot requested a review from a team August 2, 2022 10:29
@Borda
Copy link
Collaborator

Borda commented Aug 26, 2022

@ethanwharris mind check the comments so we can merge it :)

@Borda
Copy link
Collaborator

Borda commented Sep 7, 2022

@ethanwharris, mind checking the remaining comments? :)

@ethanwharris ethanwharris enabled auto-merge (squash) September 15, 2022 12:42
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #13971 (699a19c) into master (7dbd038) will increase coverage by 1%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #13971     +/-   ##
=========================================
+ Coverage      84%      85%     +1%     
=========================================
  Files         394      327     -67     
  Lines       28603    25860   -2743     
=========================================
- Hits        23900    21952   -1948     
+ Misses       4703     3908    -795     

@ethanwharris ethanwharris added this to the app:0.6.x milestone Sep 15, 2022
@ethanwharris ethanwharris merged commit 81c53fd into master Sep 15, 2022
@ethanwharris ethanwharris deleted the bugfix/drive_invalidate_cache branch September 15, 2022 14:58
krshrimali pushed a commit that referenced this pull request Sep 16, 2022
lexierule pushed a commit that referenced this pull request Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app (removed) Generic label for Lightning App package bug Something isn't working ready PRs ready to be merged

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants