-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fix mypy errors attributed to pytorch_lightning.core.saving
#13932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@awaelchli @carmocca @Borda @otaj |
awaelchli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, the previous version was in a much better state and ready to merge. I think we should leave refactors and re-definitions in unrelated files for separate PRs.
src/pytorch_lightning/trainer/connectors/logger_connector/result.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Rohit Gupta <[email protected]>
for more information, see https://pre-commit.ci
suggestion: #13932 (comment) Co-authored-by: Rohit Gupta <[email protected]>
suggestion: #13932 (comment) Co-authored-by: Rohit Gupta <[email protected]>
|
@Borda I believe this was incorrectly milestoned |
well yes, I think it can be any release, just was thinking that all this typing included would simplify eventual future cherry-picking as it lowers the diff between master and releases branch |
|
There's some risk involved in typing PRs (example) so we want to minimize it for bug-fix releases. |
What does this PR do?
Fix mypy errors attributed to
pytorch_lightning.core.savingfor issue #13445Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list: