Skip to content

Conversation

@jxtngx
Copy link
Contributor

@jxtngx jxtngx commented Jul 29, 2022

What does this PR do?

Fix mypy errors attributed to pytorch_lightning.core.saving for issue #13445

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@jxtngx jxtngx mentioned this pull request Jul 29, 2022
52 tasks
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 1, 2022
@jxtngx jxtngx marked this pull request as ready for review August 1, 2022 15:37
@jxtngx jxtngx requested a review from Borda August 8, 2022 13:04
@jxtngx
Copy link
Contributor Author

jxtngx commented Aug 8, 2022

@awaelchli @carmocca @Borda @otaj I made a few changes to standardize annotations for map_location across all files that use load_checkpoint. The new annotation uses Carlos' recent change in pl.utilities.cloud_io and adds Callable into the annotation based on doc strings for checkpoint_plugin.CheckpointIO.load_checkpoint describing map_location. The new annotation is made available in types as MAP_LOCATION.

@jxtngx jxtngx requested a review from ananthsub as a code owner August 8, 2022 13:25
@Borda Borda modified the milestones: pl:1.8, all:next Aug 8, 2022
@awaelchli awaelchli dismissed their stale review August 8, 2022 14:29

new changes have been added

Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, the previous version was in a much better state and ready to merge. I think we should leave refactors and re-definitions in unrelated files for separate PRs.

@mergify mergify bot removed the ready PRs ready to be merged label Aug 8, 2022
@awaelchli awaelchli enabled auto-merge (squash) August 8, 2022 19:35
@mergify mergify bot added the ready PRs ready to be merged label Aug 8, 2022
@awaelchli awaelchli mentioned this pull request Aug 8, 2022
11 tasks
@awaelchli awaelchli merged commit 82d2d1d into Lightning-AI:master Aug 8, 2022
@carmocca carmocca modified the milestones: all:next, pl:1.8 Aug 9, 2022
@carmocca
Copy link
Contributor

carmocca commented Aug 9, 2022

@Borda I believe this was incorrectly milestoned

@Borda
Copy link
Collaborator

Borda commented Aug 9, 2022

@Borda I believe this was incorrectly milestoned

well yes, I think it can be any release, just was thinking that all this typing included would simplify eventual future cherry-picking as it lowers the diff between master and releases branch

@carmocca
Copy link
Contributor

carmocca commented Aug 9, 2022

There's some risk involved in typing PRs (example) so we want to minimize it for bug-fix releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code quality community This PR is from the community data handling Generic data-related topic pl Generic label for PyTorch Lightning package ready PRs ready to be merged

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants