-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Snapshot selected globals and restore them in spawned process #13921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…fix/spawn-globals-2
awaelchli
commented
Jul 29, 2022
akihironitta
approved these changes
Jul 29, 2022
Contributor
akihironitta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
carmocca
approved these changes
Jul 31, 2022
Borda
approved these changes
Aug 1, 2022
rohitgr7
approved these changes
Aug 1, 2022
tchaton
approved these changes
Aug 1, 2022
Contributor
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
kaushikb11
approved these changes
Aug 1, 2022
Codecov Report
@@ Coverage Diff @@
## master #13921 +/- ##
=========================================
+ Coverage 61% 76% +15%
=========================================
Files 335 335
Lines 26305 26368 +63
=========================================
+ Hits 16048 20137 +4089
+ Misses 10257 6231 -4026 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
strategy: ddp
DistributedDataParallel
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #12685
The problem: Globals like torch deterministic flags or the seed get lost when spawning processes. This is caused because essentially the torch module gets re-imported in the child process, leading to globals being re-initialized. This is simply the nature of how
mp.spawnworks. This means it only affects ddp spawn (multiprocessing start method "spawn").We can solve this by picking the globals we care about, save them, send them to the child process and restore them there before we launch the trainer run methods. Hence, this PR implements this directly in the launcher.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @Borda @justusschock @kaushikb11 @awaelchli @akihironitta @rohitgr7