Skip to content

Conversation

@thongonary
Copy link
Contributor

@thongonary thongonary commented Jul 28, 2022

What does this PR do?

You guys added bf16 support to DeepSpeedStrategy but forgot to remove the constraint This is only compatible with precision=16 in the docstring.

This PR will save people like me a few minutes reading the source code to make sure bf16 can be used for DeepSpeedStrategy.

Does your PR introduce any breaking changes? If yes, please list them.

Not at all.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 28, 2022
@thongonary thongonary changed the title Remove fp16 restriction in the docstring Remove fp16 restriction in the docstring for DeepSpeedStrategy Jul 28, 2022
@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #13919 (d1cd7ef) into master (7fe5d4b) will decrease coverage by 3%.
The diff coverage is n/a.

❗ Current head d1cd7ef differs from pull request most recent head 1ad6f6e. Consider uploading reports for the commit 1ad6f6e to get more accurate results

@@            Coverage Diff             @@
##           master   #13919      +/-   ##
==========================================
- Coverage      79%      76%      -3%     
==========================================
  Files         103      335     +232     
  Lines        6833    26342   +19509     
==========================================
+ Hits         5425    20111   +14686     
- Misses       1408     6231    +4823     

@awaelchli awaelchli added docs Documentation related strategy: deepspeed labels Jul 29, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Jul 29, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jul 29, 2022
@awaelchli awaelchli enabled auto-merge (squash) August 3, 2022 23:52
@awaelchli awaelchli merged commit 9301a6b into Lightning-AI:master Aug 4, 2022
@thongonary thongonary deleted the patch-1 branch August 4, 2022 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related pl Generic label for PyTorch Lightning package ready PRs ready to be merged strategy: deepspeed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants