Skip to content

Fix mypy errors attributed to pytorch_lightning/profilers/base.py #13879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Fix mypy errors attributed to pytorch_lightning/profilers/base.py #13879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
731d512
Argument type error is fixed
LeeChanHyuk Jul 28, 2022
53629b0
pyproject.toml is modified
LeeChanHyuk Jul 28, 2022
a3e1fda
Argument error is fixed
LeeChanHyuk Jul 28, 2022
21c2bb2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ module = [
"pytorch_lightning.demos.boring_classes",
"pytorch_lightning.demos.mnist_datamodule",
"pytorch_lightning.loggers.neptune",
"pytorch_lightning.profilers.base",
"pytorch_lightning.profilers.pytorch",
"pytorch_lightning.profilers.simple",
"pytorch_lightning.strategies.ddp",
Expand Down
7 changes: 4 additions & 3 deletions src/pytorch_lightning/profilers/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@
# limitations under the License.
"""Profiler to check if there are any bottlenecks in your code."""
from abc import ABC, abstractmethod
from typing import Any
from pathlib import Path
from typing import Any, Optional, Union

from pytorch_lightning.profilers.profiler import Profiler
from pytorch_lightning.utilities.rank_zero import rank_zero_deprecation
Expand Down Expand Up @@ -57,11 +58,11 @@ class BaseProfiler(Profiler):
Please use `Profiler` instead.
"""

def __init__(self, *args, **kwargs):
def __init__(self, dirpath: Optional[Union[str, Path]], filename: Optional[str]):
rank_zero_deprecation(
"`BaseProfiler` was deprecated in v1.6 and will be removed in v1.8. Please use `Profiler` instead."
)
super().__init__(*args, **kwargs)
super().__init__(dirpath=dirpath, filename=filename)


class PassThroughProfiler(Profiler):
Expand Down