Skip to content

Conversation

@raoakarsha
Copy link
Contributor

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@raoakarsha raoakarsha marked this pull request as draft July 26, 2022 17:31
@raoakarsha raoakarsha marked this pull request as ready for review July 26, 2022 17:35
@carmocca carmocca added this to the pl:1.7 milestone Jul 26, 2022
@carmocca carmocca added ci Continuous Integration strategy: ipu (removed) accelerator: ipu (removed) Intelligence Processing Unit and removed strategy: ipu (removed) labels Jul 26, 2022
@akihironitta akihironitta changed the title Correct test path to publish test results CI: Correct test path to publish test results Jul 26, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jul 26, 2022
@mergify mergify bot requested a review from a team July 26, 2022 17:49
@kaushikb11 kaushikb11 merged commit a90ef3b into Lightning-AI:master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accelerator: ipu (removed) Intelligence Processing Unit ci Continuous Integration ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants