Skip to content

Conversation

@jerome-habana
Copy link
Contributor

Signed-off-by: Jerome [email protected]

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 25, 2022
Signed-off-by: Jerome <[email protected]>
jerome-habana and others added 2 commits July 25, 2022 11:09
@jerome-habana jerome-habana requested a review from kaushikb11 July 25, 2022 06:54
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #13819 (0d1bbad) into master (91bdacf) will increase coverage by 15%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #13819     +/-   ##
=========================================
+ Coverage      61%      76%    +15%     
=========================================
  Files         335      335             
  Lines       26305    26576    +271     
=========================================
+ Hits        16048    20261   +4213     
+ Misses      10257     6315   -3942     

@rohitgr7 rohitgr7 added this to the pl:1.7 milestone Jul 25, 2022
@carmocca carmocca modified the milestones: pl:1.7, pl:1.8 Jul 25, 2022
@mergify mergify bot removed the has conflicts label Jul 29, 2022
@kaushikb11 kaushikb11 self-assigned this Jul 29, 2022
@mergify mergify bot added the ready PRs ready to be merged label Aug 1, 2022
@github-actions github-actions bot removed the pl Generic label for PyTorch Lightning package label Aug 1, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 1, 2022
@kaushikb11 kaushikb11 merged commit b3203d9 into Lightning-AI:master Aug 2, 2022
@rohitgr7 rohitgr7 modified the milestones: pl:1.8, pl:1.7 Aug 2, 2022
@jerome-habana jerome-habana deleted the hpu_stats branch August 3, 2022 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accelerator: hpu (external) Habana Processing Unit callback: device stats pl Generic label for PyTorch Lightning package ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants