Skip to content

Conversation

@nninept
Copy link
Contributor

@nninept nninept commented Jul 21, 2022

What does this PR do?

Fixes mypy typing errors in pytorch_lightning/profilers/advanced.py in #13445.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 21, 2022
@nninept nninept closed this Jul 21, 2022
@nninept nninept deleted the 13445-advanced branch July 21, 2022 16:35
@nninept nninept restored the 13445-advanced branch July 21, 2022 16:35
@nninept nninept reopened this Jul 21, 2022
@nninept nninept changed the title 13445 advanced Fix mypy errors attributed to pytorch_lightning/profilers/advanced.py Jul 21, 2022
@otaj otaj mentioned this pull request Jul 21, 2022
52 tasks
@awaelchli awaelchli added this to the pl:1.7 milestone Jul 21, 2022
@carmocca carmocca added the community This PR is from the community label Jul 21, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jul 21, 2022
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #13792 (7706844) into master (238c991) will decrease coverage by 10%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #13792     +/-   ##
=========================================
- Coverage      86%      76%    -10%     
=========================================
  Files         327      327             
  Lines       25505    25505             
=========================================
- Hits        21903    19455   -2448     
- Misses       3602     6050   +2448     

@otaj otaj enabled auto-merge (squash) July 22, 2022 11:34
@otaj otaj merged commit 0b842b9 into Lightning-AI:master Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code quality community This PR is from the community pl Generic label for PyTorch Lightning package ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants