Skip to content

Fix mypy errors attributed to pytorch_lightning.callbacks.quantization #13782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Aug 19, 2022
Merged

Fix mypy errors attributed to pytorch_lightning.callbacks.quantization #13782

merged 14 commits into from
Aug 19, 2022

Conversation

@krishnakalyan3
Copy link
Contributor

@krishnakalyan3 krishnakalyan3 commented Jul 21, 2022

Part of #13445

@krishnakalyan3 krishnakalyan3 marked this pull request as draft July 21, 2022 10:28
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 21, 2022
@codecov
Copy link

codecov bot commented Jul 21, 2022 •
edited
Loading

Codecov Report

Merging #13782 (e534e9c) into master (b3203d9) will decrease coverage by 10%.
The diff coverage is 100%.

❗ Current head e534e9c differs from pull request most recent head 1b77c58. Consider uploading reports for the commit 1b77c58 to get more accurate results

@@            Coverage Diff            @@
##           master   #13782     +/-   ##
=========================================
- Coverage      85%      75%    -10%     
=========================================
  Files         335      327      -8     
  Lines       26371    26632    +261     
=========================================
- Hits        22423    19851   -2572     
- Misses       3948     6781   +2833

@otaj otaj mentioned this pull request Jul 21, 2022
Closed
52 tasks
otaj
otaj reviewed Jul 27, 2022
View reviewed changes
otaj
otaj reviewed Aug 2, 2022
View reviewed changes
@krishnakalyan3 krishnakalyan3 marked this pull request as ready for review August 10, 2022 07:56
@krishnakalyan3
Copy link
Contributor Author

krishnakalyan3 commented Aug 10, 2022

Thank you for all the reviews @otaj and for helping with this PR.

@krishnakalyan3 krishnakalyan3 requested review from otaj and removed request for SeanNaren August 10, 2022 08:46
otaj
otaj previously approved these changes Aug 10, 2022
View reviewed changes
@otaj otaj dismissed their stale review August 10, 2022 13:50

Failing tests

otaj
otaj reviewed Aug 10, 2022
View reviewed changes
@mergify mergify bot added the ready PRs ready to be merged label Aug 12, 2022
@awaelchli awaelchli enabled auto-merge (squash) August 12, 2022 11:33
@awaelchli awaelchli added this to the pl:1.8 milestone Aug 12, 2022
@krishnakalyan3
Copy link
Contributor Author

krishnakalyan3 commented Aug 15, 2022

Thank you for all the feedback @otaj and @awaelchli

@awaelchli awaelchli merged commit 0ca3b5a into Lightning-AI:master Aug 19, 2022
@krishnakalyan3
Copy link
Contributor Author

krishnakalyan3 commented Aug 20, 2022 •
edited
Loading

Thank you for the reviews @rohitgr7 @carmocca

@krishnakalyan3 krishnakalyan3 deleted the mypy_quant branch August 20, 2022 09:22
nicolai86 pushed a commit that referenced this pull request Aug 23, 2022
@krishnakalyan3 @otaj
@awaelchli @nicolai86
Fix mypy errors attributed to `pytorch_lightning.callbacks.quantizati…
f7cbd05 
…on` (#13782)


Co-authored-by: otaj <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

4 more reviewers

@awaelchli awaelchli awaelchli approved these changes

@otaj otaj otaj approved these changes

@carmocca carmocca carmocca approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code quality pl Generic label for PyTorch Lightning package ready PRs ready to be merged

Projects

None yet

Milestone

v1.8

Development

Successfully merging this pull request may close these issues.

5 participants

@krishnakalyan3 @awaelchli @otaj @carmocca @rohitgr7