Skip to content

Conversation

@otaj
Copy link
Contributor

@otaj otaj commented Jul 14, 2022

What does this PR do?

Increase minimal typing_extensions as a followup to #13631

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @awaelchli @akihironitta @carmocca

@otaj otaj added reproducibility pl Generic label for PyTorch Lightning package labels Jul 14, 2022
@otaj otaj added this to the pl:1.6.x milestone Jul 14, 2022
@otaj otaj requested a review from williamFalcon as a code owner July 14, 2022 14:13
@otaj otaj self-assigned this Jul 14, 2022
@github-actions github-actions bot removed the pl Generic label for PyTorch Lightning package label Jul 14, 2022
@otaj
Copy link
Contributor Author

otaj commented Jul 14, 2022

Huh, it seems it does not work as intended. Something in the dependency chain requires older version of typing_extensions, as evidenced here. @Borda, do you think you can take a look please?

@otaj
Copy link
Contributor Author

otaj commented Jul 14, 2022

It's this https://github.com/omni-us/jsonargparse/blob/v4.10.0/setup.cfg#L40. If python<3.8 (i.e. 3.7), the required major version of typing_extensions is 3, which trips our tests up, as typing_extensions<4 don't have NotRequired

@otaj
Copy link
Contributor Author

otaj commented Jul 14, 2022

So, it isn't jsonargparse, but rich, since it's using poetry. At least I think so, just pushed a commit and we'll see if the CI likes it 😄

@lexierule lexierule merged commit 4e2ddc4 into master Jul 14, 2022
@lexierule lexierule deleted the bugfix/typing_extensions branch July 14, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants