Skip to content

Conversation

@rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Jul 12, 2022

What does this PR do?

#13245 (comment)
discussed on slack

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • [ x Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @akihironitta @Borda

@rohitgr7 rohitgr7 added the ci Continuous Integration label Jul 12, 2022
@rohitgr7 rohitgr7 added this to the pl:1.7 milestone Jul 12, 2022
@akihironitta akihironitta added tests and removed ci Continuous Integration labels Jul 12, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jul 12, 2022
@rohitgr7 rohitgr7 enabled auto-merge (squash) July 12, 2022 12:46
@lexierule lexierule disabled auto-merge July 12, 2022 13:51
@lexierule lexierule merged commit dba65be into master Jul 12, 2022
@lexierule lexierule deleted the tests/red_bs_test branch July 12, 2022 13:51
jerome-habana pushed a commit to jerome-habana/lightning that referenced this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready PRs ready to be merged tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants