Skip to content

Conversation

@akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Jul 8, 2022

What does this PR do?

  • Fixes the current failures in nightly docker image builds.
  • Unifies the following docker-related workflows into one workflow file:
    • docker build .github/workflows/ci-pytorch_dockers.yml
    • docker build & push .github/workflows/events-nightly.yml

Motivation

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • [rfc] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @akihironitta @Borda

@akihironitta akihironitta force-pushed the ci/refactor-docker branch 4 times, most recently from 9bdf4fa to d7e31c0 Compare July 9, 2022 06:17
@akihironitta akihironitta changed the title [wip] cicd/refactor docker CI: Refactor building docker images in CI/CD Jul 9, 2022
@akihironitta akihironitta added the ci Continuous Integration label Jul 9, 2022
@akihironitta akihironitta added this to the pl:1.7 milestone Jul 9, 2022
@akihironitta akihironitta marked this pull request as ready for review July 9, 2022 06:38
@akihironitta akihironitta changed the title CI: Refactor building docker images in CI/CD CI/CD: Refactor building docker images Jul 9, 2022
@akihironitta akihironitta requested a review from Borda July 10, 2022 03:16
Copy link
Collaborator

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's rename it as ci-cd-pytorch_dockers.yml as it covers also releasing

@Borda Borda requested a review from a team July 11, 2022 13:16
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to consider fixing the commit history and doing a rebase and merge to maintain the file's git history. Or renaming the file in a separate PR

LGTM either way!

Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say rebase and merge... if not too hard.

@mergify mergify bot added the ready PRs ready to be merged label Jul 11, 2022
@mergify mergify bot requested a review from a team July 11, 2022 17:21
@Borda Borda self-requested a review July 11, 2022 21:24
@Borda Borda force-pushed the ci/refactor-docker branch from 92ad4df to 44536ac Compare July 11, 2022 21:37
@Borda Borda enabled auto-merge (squash) July 11, 2022 21:38
@Borda Borda merged commit 6f51932 into master Jul 12, 2022
@Borda Borda deleted the ci/refactor-docker branch July 12, 2022 10:08
jerome-habana pushed a commit to jerome-habana/lightning that referenced this pull request Jul 14, 2022
* Refactor docker builds in CI
* Reduce duplicate and merge two workflows
* push: bool expression
* Extend timeout for ipu builds
* Update concurrency group
* Define env for push to hub
* Rename workflow
* Fix bool expressions
* Remove unnecessary trigger paths
* Remove unused env var
* Update job names
* Trim timeout
* rename

Co-authored-by: Jirka <[email protected]>
@Borda Borda mentioned this pull request Jul 19, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants