-
Notifications
You must be signed in to change notification settings - Fork 3.6k
CI/CD: Refactor building docker images #13576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9bdf4fa to
d7e31c0
Compare
Borda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's rename it as ci-cd-pytorch_dockers.yml as it covers also releasing
carmocca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to consider fixing the commit history and doing a rebase and merge to maintain the file's git history. Or renaming the file in a separate PR
LGTM either way!
rohitgr7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say rebase and merge... if not too hard.
92ad4df to
44536ac
Compare
* Refactor docker builds in CI * Reduce duplicate and merge two workflows * push: bool expression * Extend timeout for ipu builds * Update concurrency group * Define env for push to hub * Rename workflow * Fix bool expressions * Remove unnecessary trigger paths * Remove unused env var * Update job names * Trim timeout * rename Co-authored-by: Jirka <[email protected]>
What does this PR do?
.github/workflows/ci-pytorch_dockers.yml.github/workflows/events-nightly.ymlMotivation
https://github.com/Lightning-AI/lightning/blob/61c28cb428a13c2aea6d7f3f55e0f00431a4ea4e/.github/workflows/ci-pytorch_dockers.yml#L58-L59
https://github.com/Lightning-AI/lightning/blob/61c28cb428a13c2aea6d7f3f55e0f00431a4ea4e/.github/workflows/events-nightly.yml#L70-L71
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @carmocca @akihironitta @Borda