Fix mypy errors attributed to pytorch_lightning.loggers.csv_logs.py
#13538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add annotation in ExperimentWriter __init__ - add hints in ExperimentWriter log_metrics._handle_value - update CSVLogger __init__ - update CSVLogger root_dir return - ignore CSVLogger experiment property decorator - update CSVLogger version return type - update CSVLogger _get_next_version return type
akihironitta
added
logger: csv
code quality
community
annotated self._experiment as ExperimentWriter in CSVLogger __ init__ and changed if self._experiment to if hasattr to account for change
jxtngx
requested review from
Borda,
SeanNaren,
awaelchli,
carmocca,
justusschock,
kaushikb11,
rohitgr7,
tchaton and
williamFalcon
as code owners
awaelchli
reviewed
Jul 5, 2022
- improve annotations in ExperimentWriter __init__ - fix CSVLogger.log_metrics return type
awaelchli
approved these changes
Jul 6, 2022
Contributor
awaelchli
left a comment
awaelchli
left a comment
There was a problem hiding this comment.
LGTM
To get rid of the annoying _notebooks, just do
git checkout master _notebooks
git commit ...
akihironitta
changed the title
pytorch_lightning.loggers.csv_logs.py
akihironitta
approved these changes
Jul 8, 2022
Contributor
akihironitta
left a comment
akihironitta
left a comment
There was a problem hiding this comment.
@JustinGoheen Left minor comments. Looks good to me!
Also, the following PRs are waiting on checks, is there anything more I need to do before the remaining checks can run?
Let's wait for other reviews!
Co-authored-by: Akihiro Nitta <[email protected]>
otaj
approved these changes
Jul 8, 2022
carmocca
approved these changes
Jul 11, 2022
justusschock
approved these changes
Jul 12, 2022
jerome-habana
pushed a commit
to jerome-habana/lightning
that referenced
this pull request
Jul 14, 2022
…Lightning-AI#13538) Co-authored-by: Akihiro Nitta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes mypy errors attributed to pytorch_lightning.loggers.csv_logs.py for issue #13445
Fixes #<issue_number>
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃