Skip to content

fix mypy typing errors in lightning/trainer/optimizers.py #13470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2022
Merged

fix mypy typing errors in lightning/trainer/optimizers.py #13470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c554eab
fix: fix mypy typing errors in lightning/trainer/optimizers.py
gautierdag Jun 30, 2022
3865646
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 30, 2022
c379ec7
Use assert, the input type is correct
carmocca Jun 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ module = [
"pytorch_lightning.trainer.connectors.callback_connector",
"pytorch_lightning.trainer.connectors.data_connector",
"pytorch_lightning.trainer.data_loading",
"pytorch_lightning.trainer.optimizers",
"pytorch_lightning.trainer.supporters",
"pytorch_lightning.trainer.trainer",
"pytorch_lightning.tuner.batch_size_scaling",
Expand Down
5 changes: 3 additions & 2 deletions src/pytorch_lightning/trainer/optimizers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,10 @@ def init_optimizers(self, model: Optional["pl.LightningModule"]) -> Tuple[List,
"`TrainerOptimizersMixin.init_optimizers` was deprecated in v1.6 and will be removed in v1.8."
)
pl_module = self.lightning_module or model
assert isinstance(pl_module, pl.LightningModule)
return _init_optimizers_and_lr_schedulers(pl_module)

def convert_to_lightning_optimizers(self):
def convert_to_lightning_optimizers(self) -> None:
r"""
.. deprecated:: v1.6
`TrainerOptimizersMixin.convert_to_lightning_optimizers` was deprecated in v1.6 and will be removed in v1.8.
Expand All @@ -59,6 +60,6 @@ def _convert_to_lightning_optimizer(optimizer: Optimizer) -> LightningOptimizer:
break
return optimizer # type: ignore [return-value]

self.strategy._cached_lightning_optimizers = { # type: ignore [assignment]
self.strategy._cached_lightning_optimizers = {
idx: _convert_to_lightning_optimizer(opt) for idx, opt in enumerate(self.optimizers)
}